[pull] main from nodejs:main #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
* feat: Add SidebarItem, sideBarGroup and sideBar components * feat: Add styling to sideBarGroup * Update components/Common/Sidebar/index.tsx Co-authored-by: canerakdas <[email protected]> Signed-off-by: manikanta mavireddy <[email protected]> * Update types/sidebar.ts Co-authored-by: Augustin Mauroy <[email protected]> Signed-off-by: manikanta mavireddy <[email protected]> * Update components/Common/Sidebar/index.tsx Co-authored-by: canerakdas <[email protected]> Signed-off-by: manikanta mavireddy <[email protected]> * Update components/Common/Sidebar/index.tsx Co-authored-by: canerakdas <[email protected]> Signed-off-by: manikanta mavireddy <[email protected]> * Update components/Common/SidebarItem/index.module.css Co-authored-by: canerakdas <[email protected]> Signed-off-by: manikanta mavireddy <[email protected]> * Update components/Common/SidebarItem/index.tsx Co-authored-by: canerakdas <[email protected]> Signed-off-by: manikanta mavireddy <[email protected]> * feat: refactored component structure for sidebar * removed console log * Update components/Common/Sidebar/SidebarGroup/index.module.css Co-authored-by: canerakdas <[email protected]> Signed-off-by: manikanta mavireddy <[email protected]> * Update components/Common/Sidebar/SidebarGroup/index.module.css Co-authored-by: canerakdas <[email protected]> Signed-off-by: manikanta mavireddy <[email protected]> * Update components/Common/Sidebar/SidebarGroup/index.module.css Co-authored-by: canerakdas <[email protected]> Signed-off-by: manikanta mavireddy <[email protected]> * Update components/Common/Sidebar/SidebarGroup/index.tsx Co-authored-by: canerakdas <[email protected]> Signed-off-by: manikanta mavireddy <[email protected]> * Update components/Common/Sidebar/SidebarGroup/index.tsx Co-authored-by: canerakdas <[email protected]> Signed-off-by: manikanta mavireddy <[email protected]> * removed unused import * feat:refactored sidebar component removed internal state * updated styling to match ui with figma design * updated styling * minor code refactoring and updated storybook to make it look like real page * fixed lint issues * updated imports * chore: address review feedback, align with figma --------- Signed-off-by: manikanta mavireddy <[email protected]> Co-authored-by: Manikanta Mavireddy <[email protected]> Co-authored-by: canerakdas <[email protected]> Co-authored-by: Augustin Mauroy <[email protected]> Co-authored-by: Brian Muenzenmeyer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )