Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] main from nodejs:main #297

Merged
merged 7 commits into from
Oct 30, 2023
Merged

[pull] main from nodejs:main #297

merged 7 commits into from
Oct 30, 2023

Conversation

pull[bot]
Copy link

@pull pull bot commented Oct 28, 2023

See Commits and Changes for more details.


Created by pull[bot]

Can you help keep this open source service alive? 💖 Please sponsor : )

AugustinMauroy and others added 5 commits October 28, 2023 09:25
* feat(themeToggle): introduce

* fix

* remove `ThemeProvider` from `preview.tsx`

* update to use focus and `onKeyDown`

* fix: code format

* use classname instead of css module

* remove toggling

* fix: indentation

* test: render put on `beforeEach`

* separate icon

* update

* chore: code review changes

* fix: style indentation

* meta: corrected designs of themetoggle and languagedropdown

---------

Co-authored-by: Claudio Wunder <[email protected]>
* add lighthouse preview

* add more than one url

* remove unneeded step

* use other vercel action

* remove unnecessary condition

* checkout forked branch again

* increase vercel timeout

* use correct filename

* update pull-request comment

* tun assertions

* add more than one url a different way

* format lighthouse output

* fix typo

* set locale in urls

* remove unused config

* format result

* use same comment on final result

* make valid cjs module

* comment todo

* formatting scores

* revert longer timeout

* formatting

* increase vercel timeout afterall

* add more comment

* change to ESM

* add /en/about page

* Revert "change to ESM"

This reverts commit db8b02a.

* add previous releases page

* condensed output

* add blog

* cleanup

* do not run on push

* simplify comment, trigger change

* troubleshoot why links output is empty

* testing lighthouse

* chore: simplify code, add tests

* use renamed function

* increase vercel preview timeout
* add openssf badge to new security page

* fix: overeager global padding avoided
…dy for translation (#6058)

* fix: always enforce date objs

* chore: normalise template

* meta: remove extra frontmatter fields from blog pages

* chore: pagination no author

* meta: updated components and exports for mdx

* chore: updated some links

* chore: do not translate deprecated download pages for now

* meta: only do not translate guides

* fix: localized link change approach

* meta: normalise markdown files (2)

* meta: normalisation of markdown (3)

* meta: fixed internal links to not use https://nodejs.org

* meta: updated translations

* chore: removed language picker from legacy-main
@github-actions
Copy link

Note

Your Pull Request seems to be updating Translations of the Node.js Website.

Whilst we appreciate your intent; Any Translation update should be done through our Crowdin Project.
We recommend giving a read on our Translation Guidelines.

Thank you!

@guardrails
Copy link

guardrails bot commented Oct 28, 2023

⚠️ We detected 1 security issue in this pull request:

Hard-Coded Secrets (1)
Severity Details Docs
Medium Title: Github Key
uses: actions/github-script@d7906e4ad0b1822421a7e6a35d5ca353c962f410 # v6.4.1
📚

More info on how to fix Hard-Coded Secrets in General.


👉 Go to the dashboard for detailed results.

📥 Happy? Share your feedback with us.

@pull pull bot added the ⤵️ pull label Oct 28, 2023
JulioGsn and others added 2 commits October 30, 2023 10:33
* feat: sidenav support recursive items

* feat: added learn layout

* feat: added learn navigation

* feat: added new translation ids

* feat: mark docs as archive

* chore: improved styles, use grid system

* feat: added learn pages, removed duplicated/outdated guides

* chore: added images

* meta: crowdin no translations for learn

* chore: updated redirects

* meta: no need of package-name for private package

* Apply suggestions from code review

Co-authored-by: canerakdas <[email protected]>
Signed-off-by: Claudio W <[email protected]>

* style: use flexboxes

* chore: self-code-review and adjustments

---------

Signed-off-by: Claudio W <[email protected]>
Co-authored-by: canerakdas <[email protected]>
@pull pull bot merged commit c72dc04 into NOUIY:main Oct 30, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants