Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides the needed test for the domain layer code implentation. It contains a unit test for the domain layer configuration parsing, creates a domain layer realization configuration file. The realization config file is used for running ngen executable on the domain layer.
With the latest revision, the domain layer output will be written to:
domain_layer_layer_1.csv
domain_layer_layer_2.csv
domain_layer_layer_3.csv
By default, the surface layer output will be written to usual catchment and nexus output files.
Additions
Unit test code
two realization onfig json files
Removals
Changes
Minor change to
src/NGen.cpp
andinclude/realizations/config/layer.hpp
Testing
On local linux machine
Running ngen executable on domain layer, for example:
./cmake_build/ngen ./data/catchment_data.geojson '' ./data/nexus_data.geojson '' data/example_domainlayer_realization_config.json
Running ngen executable on domain layer with a multilayer hydrofabric and realization config.
./cmake_build/ngen ./data/catchment_data_multilayer.geojson '' ./data/nexus_data.geojson '' data/example_domainlayer_multilayer_realization_config.json
This will generate an additional output file: domain_layer_layer_4.csv
Unit test
Screenshots
Notes
Todos
Checklist
Testing checklist (automated report can be put here)
Target Environment support