-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add NextGen CONUS Documentation #854
base: master
Are you sure you want to change the base?
Conversation
doc/DEPENDENCIES.md
Outdated
@@ -14,7 +14,7 @@ | |||
| [pybind11](#pybind11) | submodule | `v2.6.0` | Can be [excluded](#overriding-pybind11-dependency). | | |||
| [dmod.subsetservice](#the-dmodsubsetservice-package) | external | `>= 0.3.0` | Only required to perform integrated [hydrofabric file subdividing](DISTRIBUTED_PROCESSING.md#subdivided-hydrofabric) for distributed processing . | | |||
| [t-route](#t-route) | submodule | see below | Module required to enable channel-routing. Requires pybind11 to enable | | |||
| [NetCDF Libraries](#netcdf-libraries) | external | \>= `4.7.4` | Enables NetCDF I/O support | | |||
| [NetCDF Libraries](#netcdf-libraries) | external | NetCDF-C \>= `4.7.4`, CXX \>= `4.3.1`, Fortran \>= `4.5.4` | Enables NetCDF I/O support | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we require the NetCDF Fortran support for ngen itself? I can readily believe that it's necessary for some of the formulations in the set we give examples for. That may be reason enough to document it as required here, maybe with a note about why.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NetCDF Fortran is not necessary, at least for now, so I simply removed it.
Good point. In our tests we always linked in the whole NetCDF directory so
everything is made available. Since it is for I/O support, maybe NetCDF
Fortran is not really necessary, at least for now.
…On Mon, Sep 2, 2024 at 5:01 PM Phil Miller - NOAA ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In doc/DEPENDENCIES.md
<#854 (comment)>:
> @@ -14,7 +14,7 @@
| [pybind11](#pybind11) | submodule | `v2.6.0` | Can be [excluded](#overriding-pybind11-dependency). |
| [dmod.subsetservice](#the-dmodsubsetservice-package) | external | `>= 0.3.0` | Only required to perform integrated [hydrofabric file subdividing](DISTRIBUTED_PROCESSING.md#subdivided-hydrofabric) for distributed processing . |
| [t-route](#t-route) | submodule | see below | Module required to enable channel-routing. Requires pybind11 to enable |
-| [NetCDF Libraries](#netcdf-libraries) | external | \>= `4.7.4` | Enables NetCDF I/O support |
+| [NetCDF Libraries](#netcdf-libraries) | external | NetCDF-C \>= `4.7.4`, CXX \>= `4.3.1`, Fortran \>= `4.5.4` | Enables NetCDF I/O support |
Do we require the NetCDF Fortran support for ngen itself? I can readily
believe that it's necessary for some of the formulations in the set we give
examples for. That may be reason enough to document it as required here,
maybe with a note about why.
—
Reply to this email directly, view it on GitHub
<#854 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACA4SRNYE5OISUZZOLITNC3ZUTNZPAVCNFSM6AAAAABKNPPWC2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDENZWGE3TEMZQG4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
This PR update documentation to cover all aspect on computations at CONUS scale involving all submodules so far known to be suitable running within ngen framework. One of the purposes is to summarize previous piece meal documentations in one place.
Additions
Removals
Changes
Updates doc/NextGen_ON_CONUS.md
Testing
Visualization in browser
Screenshots
Notes
This is the final draft version for baseline computation on CONUS.
Todos
Checklist
Testing checklist (automated report can be put here)
Target Environment support