Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor changes to Forcings Engine Data Provider for derived implementations #851

Merged

Conversation

program--
Copy link
Contributor

@program-- program-- commented Jul 3, 2024

This PR makes 2 changes to support derived implementations:

  1. Moves timing and configuration file path member variables outside of private scope into protected so derived implementations can directly access these.
  2. Adds ForcingsEngineDataProvider::ensure_variable, which is a helper function that helps handle variable name aliasing from what NGen expects to what the forcings engine expects.

Additions

  • ForcingsEngineDataProvider::ensure_variable

Changes

  • init_, time_begin_, time_end_, and time_step_ from private to protected scope.

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

@program-- program-- marked this pull request as draft July 3, 2024 20:18
@program-- program-- force-pushed the jsm-forcings-engine-provider-mod3 branch from 05b1caf to 110b9bb Compare July 24, 2024 18:38
@program-- program-- marked this pull request as ready for review July 24, 2024 18:55
@program-- program-- merged commit a63cc26 into NOAA-OWP:master Jul 24, 2024
19 checks passed
@program-- program-- deleted the jsm-forcings-engine-provider-mod3 branch July 24, 2024 19:03
@program-- program-- mentioned this pull request Aug 8, 2024
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants