Minor changes to Forcings Engine Data Provider for derived implementations #851
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes 2 changes to support derived implementations:
private
scope intoprotected
so derived implementations can directly access these.ForcingsEngineDataProvider::ensure_variable
, which is a helper function that helps handle variable name aliasing from what NGen expects to what the forcings engine expects.Additions
ForcingsEngineDataProvider::ensure_variable
Changes
init_
,time_begin_
,time_end_
, andtime_step_
fromprivate
toprotected
scope.Checklist