Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete unused stub class HY_HydroNetwork #824

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

PhilMiller
Copy link
Contributor

@PhilMiller PhilMiller commented May 24, 2024

The class HY_HydroNetwork has no substance, nor any uses. It contains a spurious reference to a collection of HY_CatchmentArea instances, which threw me off in other refactoring work.

Removals

  • class HY_HydroNetwork

Testing

  1. CI

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

@PhilMiller
Copy link
Contributor Author

There was a bit of discussion that we may want to keep something like this around for future modeling needs. However, right now, the code that's present supports nothing, and would be pretty trivial to resurrect or reproduce

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant