Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Lake Champlain USGS Water level data provider for coastal model t… #806

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jduckerOWP
Copy link

@jduckerOWP jduckerOWP commented Apr 29, 2024

Add Lake Champlain USGS Water level data provider for coastal model t…

[Short description explaining the high-level reason for the pull request]

Additions

  • @PhilMiller to include a data provider BMI to evaluate full coupling of the SCHISM Lake Champlain formulation, which includes two-way coupling of T-Route and offshore water levels forced by the USGS water level observation gauge upstream of the Lake Champlain domain.

Removals

Changes

Testing

Screenshots

Notes

Todos

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

Testing checklist (automated report can be put here)

Target Environment support

  • Linux

…esting as a formulation under the NextGen framework
@jduckerOWP
Copy link
Author

@PhilMiller Here is the BMI development of the USGS water level gauge data provider for you to test and evaluate SCHISM in a fully coupled NextGen formulation. I'll be happy to address any questions or concerns you may have. Keep in mind that I'm only proposing a new repository potential for "BMI water level data providers" but I'll be happy to discuss this accordingly with how the model engine team wants to move forward with that data provider integration into the NextGen framework.

@PhilMiller PhilMiller marked this pull request as draft April 29, 2024 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant