Simplify HY_Features_MPI via subclassing #668
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhilMiller
reviewed
Nov 2, 2023
hellkite500
force-pushed
the
simplify-mpi-collection
branch
from
5e4a9bc
to
8250d1f
Compare
program--
reviewed
Nov 2, 2023
Comment on lines
34
to
35
| std::unordered_map<std::string, std::shared_ptr<HY_Catchment>> _catchments; | ||
| std::unordered_map<std::string, std::shared_ptr<HY_PointHydroNexusRemote>> _nexuses; |
There was a problem hiding this comment.
Since this class now inherits from HY_Features, shouldn't these be protected in that class and these removed? I think this shadows those variables, but there are two "instances" of _catchments in this class now IIRC, just one of them is not accessible (I could be wrong here haha)
There was a problem hiding this comment.
I missed that, only looked at the changes but this is correct.
|
How's the test coverage on this? Automated and/or manual? |
donaldwj
requested changes
Nov 2, 2023
10 tasks
program--
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maintaining the
HY_Features_MPIcollection class as a completely independent unit seems to have lead to significant code duplication and has been the source of some errors in previous work, e.g. layers. This PR attempts to isolate the logic specific to the MPI collection and reuse the base components as much as possible.Changes
HY_Features_MPIa true subclass ofHY_Features_MPIand remove redundant codeChecklist
Target Environment support