[1pt] PR: dev-bathymetric-adjustment

[hhs732]

This PR focuses on adjusting rating curves by using bathymetric data. The bathymetry data includes eHydro surveys and AI-based datasets created for all NWM streams.

Changes

• src/bathymetric-adjustment.py: 'correct_rating_for_ai_based_bathymetry" function was added to the script. This function processes AI-based bathymetry data and adjusts rating curves using this data. Also "apply_src_adjustment_for_bathymetry' function was added to prioritize USACE eHydro over AI-based bathymetry dataset. Multi-processing function "multi_process_hucs" was also updated based on the latest code.

• src/bash_variables.env: New variables and their paths were added.

• fim_post_processing.sh: New arguments were added.

Testing

This PR has been tested on 11 HUC8s around the Illinois River and Ohio River.

Deployment Plan (For developer use)

How does the changes affect the product?

• Code only?
• Require new or adjusted data inputs? Does it have start, end and duration code (in UTC)?
• If new or updated data sets, has the FIM code been updated and tested with the new/adjusted data (subset is fine, but must be a subset of the new data)?
• Require new pre-clip set?
• Has new or updated python packages?
• If applicable, has a deployment plan be created with the deployment person/team?

Issuer Checklist (For developer use)

You may update this checklist before and/or after creating the PR. If you're unsure about any of them, please ask, we're here to help! These items are what we are going to look for before merging your code.

• Informative and human-readable title, using the format: [_pt] PR: <description>
• Links are provided if this PR resolves an issue, or depends on another other PR
• If submitting a PR to the dev branch (the default branch), you have a descriptive Feature Branch name using the format: dev-<description-of-change> (e.g. dev-revise-levee-masking)
• Changes are limited to a single goal (no scope creep)
• The feature branch you're submitting as a PR is up to date (merged) with the latest dev branch
• pre-commit hooks were run locally
• Any change in functionality is tested
• Passes all unit tests locally (inside interactive Docker container, at /foss_fim/, run: pytest unit_tests/)
• New functions are documented (with a description, list of inputs, and expected output)
• Placeholder code is flagged / future todos are captured in comments
• CHANGELOG updated with template version number, e.g. 4.x.x.x
• Reviewers requested
• Add yourself as an assignee in the PR as well as the FIM Technical Lead

Merge Checklist (For Technical Lead use only)

• Update CHANGELOG with latest version number and merge date
• Update the Citation.cff file to reflect the latest version number in the CHANGELOG
• If applicable, update README with major alterations

[hhs732]

The FIM pipeline was run with three scenarios, including bathy_adjustment off, bathy on streams with order 7 or higher, and bathy on streams with order 4 or higher. The alpha test was then done on the results. Results and plots are stored here:

/efs-drives/fim-dev-efs/fim-home/heidi.safa/aib_bathy_adjustment/stream_orders_research/alpha_test/