[1pt] PR: Updating bathymetry-preprocessing script

[hhs732]

This PR focuses on updating the preprocess_bathymetry.py for 3 issues: 1) the capability of preprocessing SurveyJobs that have negative depth values, 2) changing the SurveyDateStamp format, and 3) the capability of including multiple SurveyJobs for one NWM feature-id if needed.

Changes

• data/bathymetry/preprocess_bathymetry.py: Addressing 3 issues including, the capability of preprocessing SurveyJobs that have negative depth values, changing the SurveyDateStamp format, and the capability of including multiple SurveyJobs for one NWM feature-id.

Testing

This PR has been tested on 25 SurveyJobs over the Illinois River.

Issuer Checklist (For developer use)

You may update this checklist before and/or after creating the PR. If you're unsure about any of them, please ask, we're here to help! These items are what we are going to look for before merging your code.

• Informative and human-readable title, using the format: [_pt] PR: <description>
• Links are provided if this PR resolves an issue, or depends on another other PR
• If submitting a PR to the dev branch (the default branch), you have a descriptive Feature Branch name using the format: dev-<description-of-change> (e.g. dev-revise-levee-masking)
• N/A Changes are limited to a single goal (no scope creep)
• The feature branch you're submitting as a PR is up to date (merged) with the latest dev branch
• pre-commit hooks were run locally
• Any change in functionality is tested
• Passes all unit tests locally (inside interactive Docker container, at /foss_fim/, run: pytest unit_tests/)
• N/A New functions are documented (with a description, list of inputs, and expected output)
• N/A Placeholder code is flagged / future todos are captured in comments
• CHANGELOG updated with template version number, e.g. 4.x.x.x
• Reviewers requested
• Add yourself as an assignee in the PR as well as the FIM Technical Lead

Merge Checklist (For Technical Lead use only)

• Update CHANGELOG with latest version number and merge date
• Update the Citation.cff file to reflect the latest version number in the CHANGELOG
• If applicable, update README with major alterations

[RobHanna-NOAA]

Deployment Plan: None other than merge code. Each survey has to be run through the script one at a time and concatenated to a bathy gpkg. This updated tool is being used to update a working copies of the master bathymetry_adjustment_data.gpkg in temp working directories. Each developer will be building up there own bathy gpkgs. Periodically, likely in the summer, a separate issue card will be created to merge all working copies into a new master (or update the master) bathymetry_adjustment_data.gpkg . In that issue card, they will get it it merged, clean it up, test it then that master file can be propogated to all enviros at that time. No new or updated input deployable files exist in this PR.

[ZahraGhahremani]

I tested this PR on 36 SurveyJobs for the Upper Mississippi River. Works perfectly.

[RobHanna-NOAA]

Awesome. Let's get the current dev moved in, do a quick test on it and we should be able to get it merged in. Nice work ladies. :)

[ZahraGhahremani]

Awesome. Let's get the current dev moved in, do a quick test on it and we should be able to get it merged in. Nice work ladies. :)

Merged it with the current dev and did a quick test. All is done :)