Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support building with -Werror for ngen #106

Merged
merged 1 commit into from
Apr 2, 2024
Merged

Support building with -Werror for ngen #106

merged 1 commit into from
Apr 2, 2024

Conversation

PhilMiller
Copy link
Contributor

@PhilMiller PhilMiller commented Apr 2, 2024 •
edited
Loading

In support of NOAA-OWP/ngen#718, CFE needs to build without warnings in that setting.

Changes

  • Check the return values of the few fgets() calls in input reading.

Testing

  1. Local build no longer warns
  2. CI

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Visually tested in supported browsers and devices (see checklist below 👇)
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

Testing checklist

Target Environment support

  • Linux
  • macOS

@PhilMiller PhilMiller changed the title Fix unchecked fgets() return values Support building with -Werror for ngen Apr 2, 2024
@PhilMiller PhilMiller marked this pull request as ready for review April 2, 2024 18:18
@PhilMiller PhilMiller mentioned this pull request Apr 2, 2024
Merged
13 tasks
aaraney
aaraney approved these changes Apr 2, 2024
View reviewed changes
Copy link
Member

@aaraney aaraney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @PhilMiller!

@aaraney aaraney merged commit a3d82b1 into master Apr 2, 2024
4 checks passed
donaldwj
donaldwj approved these changes Apr 2, 2024
View reviewed changes
Copy link

@donaldwj donaldwj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always nice to see error checking added

@PhilMiller PhilMiller deleted the PhilMiller/warnings branch April 2, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaraney aaraney aaraney approved these changes

@donaldwj donaldwj donaldwj approved these changes

@ajkhattak ajkhattak Awaiting requested review from ajkhattak

@madMatchstick madMatchstick Awaiting requested review from madMatchstick

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PhilMiller @donaldwj @aaraney