LGARTO #36
Open
LGARTO #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he config file, it defaults to false.
…as the smallest adaptive time step for the rest of the model. If the adaptive time step is off, the giuh time step will be the same as the timestep input in the config file.
…er sets, including single and multi layer modes for lgarto and lgar. some cleanup and documentation still necessary.
…es, such that recharge agrees better with HYDRUS results for short, synthetic LGARTO tests. Also re introduced free drainage as a lower BC for LGAR mode, where most of the development for this was done in 2022.
…O to main. Here, I have included a notebook called LGARTO_demo, in tests, that demonstrates that there are not significant changes between LGAR and LGARTO with TO_enabled set to false. I have included the stability tests, which currently yield no unstable model runs over 160k parameter set and forcing dataset combinations, across both options for TO_enabled. I have also included notebooks that compare HYDRUS and LGARTO results for 4 short, synthetic simulations, and 4 year long simulations using real forcing and soils data from USDA SCAN sites. Finally, I have added notebooks that animate LGARTO simulations, which helps a lot with visualization and communication. Also minor edits to documentation of lgar.cxx, and moderate edits to the readme in the tests directory.
…lary drive G for improved speed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Short description explaining the high-level reason for the pull request]
Additions
In this PR, a multilayer version of the Talbot-Ogden (TO) model for fluxes between the vadose zone and groundwater has been developed and added to the model. Because the prior vadose zone model was LGAR, the new model is called LGARTO. The key benefit of LGARTO is that it explicitly simulates the presence of a shallow water table (currently assumed to be at the bottom of the model domain) and simulates both its effects on soil moisture and recharge. This allows vadose zone simulations in areas that are humid (as opposed to being restricted to arid or semi arid areas, as is the case in LGAR). The model is designed to be backwards compatible with LGAR; while the config file does have a few new lines, unspecified new lines will default to options such that the model is run in LGAR mode.
Removals
Changes
The code has been substantially expanded to incorporate the new TO model, and a new type of wetting front has been added. The LGAR component of the code has had moderate changes; most of the development is in the addition of new code.
Testing
Screenshots
Notes
Todos
Checklist
Testing checklist
Target Environment support
Accessibility
Other