Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Determine constants (such as NOW) #687

Open
Tracked by #313
christophertubbs opened this issue Jul 31, 2024 · 0 comments
Open
Tracked by #313

Determine constants (such as NOW) #687

christophertubbs opened this issue Jul 31, 2024 · 0 comments

Comments

@christophertubbs
Copy link
Contributor

christophertubbs commented Jul 31, 2024

Environment and application constants should be integrated into the parsing process to allow for configuration reuse. To do that, the constants should first be determined. These constants should be things that indicate common relative values such as directory paths and dates. NOW should absolutely be included.

All initial constants need to be determined and mapped to their meanings like so:

  • NOW: datetime.now().astimezone()

It might also be worth determining if these 'constants' need to be configurable. For instance, if there are supposed to be constants for common paths, like THRESHOLD_DIRECTORY pointing at a directory for common thresholds, allow those values to be configured in a separate file/format to allow paths to be added and removed without redeployment.

The ORM for the evaluation service would be fantastic for this as it can attach descriptions to the paths and the constants and the descriptions may be queried for further functionality elsewhere. The challenge there, though, would be that the processing happens in dmod.evaluations, not within the evaluation service, so some form of dependency injection will be required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant