Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Evaluation Configuration Variables/Expressions #313

Open
6 tasks
christophertubbs opened this issue Mar 22, 2023 · 2 comments
Open
6 tasks

Implement Evaluation Configuration Variables/Expressions #313

christophertubbs opened this issue Mar 22, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request epic A large, high-level task composed of (sub-epic) tasks wishlist Highly desired/useful to a deliverable ahead of required deadline

Comments

@christophertubbs
Copy link
Contributor

christophertubbs commented Mar 22, 2023

The configuration for an element for an evaluation might look like:

"backend": {
                "backend_type": "rest",
                "data_format": "json",
                "address": "https://nwis.waterservices.usgs.gov/nwis/iv",
                "params": {
                    "format": "json",
                    "indent": "on",
                    "sites": "0214657975,0214655255",
                    "startDT": "2022-12-01T00:00%2b0000",
                    "endDT": "2022-12-31T00:00%2b0000",
                    "parameterCd": "00060"
                }
            }

It would be useful to insert variables so that the same configuration may be used multiple times as conditions and needs change. The above configuration my look like the following with variable functionality:

"backend": {
                "backend_type": "rest",
                "data_format": "json",
                "address": "https://nwis.waterservices.usgs.gov/nwis/iv",
                "params": {
                    "format": "json",
                    "indent": "on",
                    "sites": "0214657975,0214655255",
                    "startDT": "{{ NOW - timedelta(hours=48) }}",
                    "endDT": "{{ NOW }}",
                    "parameterCd": "00060"
                }
            }

Another example could be:

"backend": {
                "backend_type": "file",
                "data_format": "rdb",
                "address": "{{ THRESHOLD_DIRECTORY }}/nwis_stat_thresholds.rdb"
            }

instead of

"backend": {
                "backend_type": "file",
                "data_format": "rdb",
                "address": "path/to/nwis_stat_thresholds.rdb"
            }

Steps:

This may be considered as done when a configuration may include strings such as "{{ NOW }} " or " {{ CONSTANT }}/path/to/whatever" may be used, are fully documented, and are have a good deal of unit tests.

@christophertubbs christophertubbs added the enhancement New feature or request label Mar 22, 2023
@christophertubbs christophertubbs self-assigned this Mar 22, 2023
@christophertubbs christophertubbs added the wishlist Highly desired/useful to a deliverable ahead of required deadline label Mar 24, 2023
@robertbartel
Copy link
Contributor

Marking as Blocked to flag the issue, as I think this may have been completed.

@robertbartel robertbartel added the epic A large, high-level task composed of (sub-epic) tasks label Aug 7, 2024
@robertbartel
Copy link
Contributor

FYI @christophertubbs, with this now being broken down nicely into subtasks, I've added the epic tag. That will keep it from being visible where it was previously in the project board, but you can still find it in the BL Multi-Task Issues view.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request epic A large, high-level task composed of (sub-epic) tasks wishlist Highly desired/useful to a deliverable ahead of required deadline
Projects
None yet
Development

No branches or pull requests

2 participants