Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the
KeyValueStore
enum async, which, of course, has a rather big impact on the code base.The enum delegates to
KeyValueStoreImpl
which is still sync. The actualDisk
andMemory
implementations are also sync. We can make this implementation async in a future a PR. We may be able to remove the indirection to theKeyValueStoreImpl
enum then as well. We will see. When this is done, we can also port thekvx
implementation for postgresql - albeit, using async.Just mentioning this here now so that it is clear that there is more work, but I intentionally wanted to keep this PR a bit smaller so that it can be reviewed better.