Skip to content

make copyright year/owner spacing consistently double spaced #687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 2, 2025

Conversation

sjvrijn
Copy link
Contributor

@sjvrijn sjvrijn commented Apr 2, 2025

Checklist before requesting a review

  • I have read the contribution guidelines
  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • My changes generate no new warnings

Type of change

Please delete options that are not relevant.

  • "Bug" fix (non-breaking change which fixes an issue)

List of related issues or pull requests**

Refs:

Describe the changes made in this pull request

Made spacing consistent in GPLv3 license text.

Instructions to review the pull request

Install the requirements

cd $(mktemp -d --tmpdir py-tmpl-XXXXXX)
pip install pipx
pipx install copier

Create a new package using the template, choosing the GPLv3 license

copier copy --vcs-ref 685-gplv3-spacing https://github.com/nlesc/python-template test_package
  • Confirm the spacing is now consistent at lines 635 and 655 of the LICENSE file

@sjvrijn sjvrijn added the generated-package Related to the generated package, i.e. after running cookiecutter label Apr 2, 2025
@sjvrijn sjvrijn requested review from fdiblen and OleMussmann April 2, 2025 23:18
Copy link
Member

@fdiblen fdiblen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @sjvrijn!
Looks good to me.
PS: Sorry for the late reaction.

@egpbos egpbos merged commit 624648f into main May 2, 2025
18 checks passed
@egpbos egpbos deleted the 685-gplv3-spacing branch May 2, 2025 11:39
@egpbos egpbos mentioned this pull request May 2, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
generated-package Related to the generated package, i.e. after running cookiecutter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants