Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove standalone label #8884

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

HyperLife1119
Copy link
Collaborator

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

In angular 19, the standalone option defaults to true, so we no longer need to emphasize that ZORRO's components are standalone or not.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Copy link

zorro-bot bot commented Nov 18, 2024

This preview will be available after the AzureCI is passed.

Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.83%. Comparing base (c3ab3ba) to head (2f3b0e9).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8884      +/-   ##
==========================================
- Coverage   91.84%   91.83%   -0.02%     
==========================================
  Files         548      548              
  Lines       19305    19305              
  Branches     2862     2862              
==========================================
- Hits        17730    17728       -2     
- Misses       1260     1261       +1     
- Partials      315      316       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Laffery Laffery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Laffery Laffery added this to the v19 milestone Nov 19, 2024
@Laffery
Copy link
Collaborator

Laffery commented Nov 19, 2024

This pr had changed too many doc files, as known that a major version might have lots of changes to doc files as well.

So please note that this pr will be merged at an extremely LATE point in time and may require a rebase :)

@Laffery
Copy link
Collaborator

Laffery commented Nov 26, 2024

@HyperLife1119 Basically all the main features of v19 are merged, please rebase from the master and this pr is gonna to be merged

@HyperLife1119 HyperLife1119 force-pushed the docs/remove-standalone-label branch from 72c74b5 to 2f3b0e9 Compare November 26, 2024 06:23
@Laffery Laffery merged commit 99d56a6 into NG-ZORRO:master Nov 26, 2024
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants