Add KICS security checks #22
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement code tests with KICS: https://kics.io/
This new workflow does the following:
Manually create an output directory
Use a predefined action to use the KICS security scanner on the whole
repository. Configured to output results in the beforementioned
directory.
Use another predefined action to upload the output in SARIF format so
GitHub can interpret and visualize all found issues.
The current configuration will not fail on any issues being detected.
Code to activate failing is still in the comments and can be re-enabled
as soon as we got the checks going and fixed the current issues.
If we enable failing on certain issue levels we should also require the
check to succeed before merging. Currently it's just informational and
will not block merging.
Predefined GitHub actions now aren't refered to by their version tag.
Instead we use SHA checksums of Git commits. (as suggested by GitHub -
see below)
Please see comments from GitHub in this PR. They will make more clear
what this all is for.
Reference:
https://docs.kics.io/latest/integrations_ghactions/
Pin all GitHub Actions to a full length commit SHA carbon-design-system/carbon#14052
https://github.com/Checkmarx/kics-github-action