-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add modis_sinusoidal as a horizCoordSysName option #353
Conversation
This looks good, @srearl. Thanks!
|
Hi @mbjones, Thank you for having a look at my request. My understanding is that this is a customized projection and, thus, does not have a epsg number, and, yes, that the sr-org number overlaps with epsg 6842 is confusing and unfortunate. Using snake case was an oversight on my part, and I will change that to title case with an underscore in a revised pull request. First, though, let me run by you a draft spatialReferenceDictionary entry.
Not sure about the |
@srearl looks good, but we do need to resolve the @brunj7 could you take a look at this and verify the proposed |
thank you @metamattj and @brunj7 - I can ask the geospatial folks here at ASU about that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not think there is an EPSG code for MODIS Sinusoidal projection. It is mainly a system for NASA to tile the data. From my experience, you generally reproject the data into another projection system when analyzing it.
This is the most detailed description of this projection I could find:
https://modis-land.gsfc.nasa.gov/GCTP.html
It does not match the sinusoidal systems in EPSG:
Note that the term MODIS Sinusoidal
is referring to 3 different projection systems:
https://spatialreference.org/ref/?search=MODIS
It is mentioned that the two versions with higher reference numbers are attempting to "correct" the original: https://spatialreference.org/ref/sr-org/modis-sinusoidal/ (which matches the definition on the above MODIS webpage). The two newer ones refer to a WGS84 ellipsoid instead of the custom one using parameters semi-major
and semi-minor
to customize it to the MODIS sinusoidal one.
I think my recommendation will be to use SR-ORG:6974's definition to write the EML projection definition as you will be able to point to defined Ellipsoid and Datum and their EPSG codes
https://spatialreference.org/ref/sr-org/modis-sinusoidal-3/html/
Hope it helps!
@brunj7 - thanks very much for your input on this issue. I had not thought about the fact that modis sinusoidal can refer to the three different projection systems that you highlighted. In fact, the investigator did not specify one of the three, having indicated only modis sinusoidal. However, regarding your suggestion to use SR-ORG:6974, the CRS of the data (as indicated by the provider and detailed when loaded into a GIS system) is Reprojecting is a possibility but not ideal as the investigator indicated that that can cause pixel values to change in the function of the resampling method. Plus, a lot of folks use MODIS data so this really seems like something we should nail down. |
That However, all of these structures were derived from a combination of early draft releases of ISO 19115 and FGDC concepts, and so within ISO, they defined the field as:
We should likely update EML's documentation to both define these fields and establish the relationship to corresponding concepts in ISO 19111. |
@mbjones - Just FYI, I wrote to the MODIS team at NASA to get some clarification about that Regarding your more general comments, it seems that attention to geospatial data/metadata within LTER has waned since Theresa retired. I document a lot of geospatial data at CAP and, while not my area of expertise, am happy to discuss how we might put more attention and effort toward addressing some of the issues you raise. cc @brunj7 |
Hi, I just joined this conversation by way of an email from @srearl Some of the confusion in the MODIS sinusoidal projection comes from the fact that the sinusoidal projection is only defined for a sphere (see https://en.wikipedia.org/wiki/Sinusoidal_projection). This means that the standard ellipsoid semi-major/semi-minor axis (and flattening factor) is not applicable. However, there are various ways of using auxiliary latitudes (see https://en.wikipedia.org/wiki/Latitude#Auxiliary_latitudes) to convert from a reference like WGS 84 (or GRS 80) datum to a spherical projection. However, most projection packages don't support auxiliary latitudes and I don't think that EPSG supports this concept, or at least it didn't 20 years ago when we were defining the parameters for the MODIS sinusoidal projection. What we did may be unconventional, because at the time I was not aware of any similar work. We computed the radius of a sphere with a surface area that was the same area as the WGS 84 ellipsoid and used this radius as the single radius (6371007.181 m) in the projection. We then used the WGS 84 geodetic latitude directly as an auxiliary latitude (projection_latitude == geodetic_latitude). We documented this and (naively?) thought that our end-users would do the same when converting from the latitude from the sinusoidal projection back to geodetic latitude. Notice, the radius I choose has two more digits of precision than the authalic (equal area) radius defined here: https://en.wikipedia.org/wiki/Earth_radius (6371007.2 m), but it the same as the IUGG 'radius of sphere of same surface (R2)' in the table (6371007.1810 m, note one more digit of precision). Note that this is similar to as for users who use geographic (equi-rectangular, plate carree, etc.) or other spherical projections (https://en.wikipedia.org/wiki/Equirectangular_projection). Note that the convention for the radius R in those projections varies as described in the Wikipedia reference above. I hope that this helps with this discussion. |
@mbjones - updated PR with a few notes:
|
Hi @mbjones - Any thoughts on this PR, I am not comfortable merging without your review? |
While in general this looks good to me, I don't have sufficient background in projections to really vet it. If you feel that you've done due diligence and this would be helpful to the EML community, then I am supportive. We should not merge this to master, which contains the current 2.2.0 release. Instead, we should merge it in the targeted branch for the next release. We haven't discussed what that release would be or its objectives. This addition should be completely backwards compatible, so it could go in either a 2.2.1 patch release, or more likely a 2.3.0 release. Frequent releases are a maintenance problem for sites, so we should strategically discuss how to best handle this and whether this patch can sit while we wait for other changes to accrue. Do you want to get this out right away? One other thing we could consider would be to externalize the vocabulary of projections so that it is independently maintainable outside of EML releases. That would allow new CRS entries to be added without a new release of EML. Something to consider. |
Thanks for reviewing this @mbjones. One concern is the ability to distinguish the same or similarly named user-defined projections using the structure in the spatialReferenceDictionary. For example, as @brunj7 had pointed out, there are three MODIS Sinusoidal projections (6842 is the one of interest here). It would seem valuable, critical really, to be able to distinguish those in the dictionary with a unique name and, ideally, to reference their respective SR-ORG identifier. In fact, it would be helpful to reference the SR-ORG identifier even when there are not multiple, similarly named references. It is not clear how to do that. I have had to punt on the issue for the dataset that started this (by describing the rasters with |
Requesting the addition of
modis_sinusoidal
as ahorizCoordSysName
option. Please see #352 for details. I am just taking a stab at naming this particular projection so am open to suggestions.