Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for LDF #371

Merged
merged 18 commits into from
Apr 7, 2025
Merged

Updates for LDF #371

merged 18 commits into from
Apr 7, 2025

Conversation

wwieder
Copy link
Collaborator

@wwieder wwieder commented Apr 6, 2025

Minor changes getting LDF to work

@wwieder wwieder requested a review from justin-richling April 7, 2025 13:53
@wwieder
Copy link
Collaborator Author

wwieder commented Apr 7, 2025

Not sure what formatting test I can run here. Otherwise, I'd like to send a link to this branch to collaborators for our work time on Thursday.

@nusbaume
Copy link
Collaborator

nusbaume commented Apr 7, 2025

@wwieder you can run the following on casper/derecho to locally perform the linting/formatting test:

module load conda
conda activate npl
pylint --rcfile=<LDF>/lib/test/pylintrc <LDF>/lib/adf_diag.py

where <LDF> is the path to your local ADF/LDF branch. I believe you'll need to get the score above 9.5 in order for the test on Github to pass. Of course if you have any questions or issues with this process just let me know. Thanks!

@wwieder wwieder merged commit d0c2b5f into NCAR:clm-diags Apr 7, 2025
7 checks passed
@wwieder
Copy link
Collaborator Author

wwieder commented Apr 7, 2025

Thanks @nusbaume. I got the pylint score to pass, seemingly without breaking anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants