-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
S3 to S3 backup and sync #577
base: master
Are you sure you want to change the base?
Conversation
@jbygdell where are the go tests run in the workflow? are they buried in some container? |
This repository never had any workflow for code tests, since there hasn't existed any test files. |
Right, I see. I tried to run them locally and I got the following:
and
What am I missing? |
A bunch of other files (non go) that interferes. run:
And you'll see that it works. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, some small things to change.
3910cea
to
53ec66f
Compare
This is so we can have multiple backends for backing up different S3 buckets.
Sometimes we don't want to backup the entire bucket.
53ec66f
to
abd4c11
Compare
Describe the pull request:
Pull request long description:
This PR add functionality to backup or sync S3 buckets in the same or different endpoints.
prefix
can be set in the config to allow only a subset of objects to be selected, object path needs to begin with the prefix, that can be a string or a path. (test
orfoo/subset/bar
)Changes made:
Related issues:
Additional information:
Release note:
Documentation change:
Mentions: