Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change MyBinder links to VEDA Binder #188

Merged
merged 6 commits into from
Jan 22, 2025
Merged

Change MyBinder links to VEDA Binder #188

merged 6 commits into from
Jan 22, 2025

Conversation

j08lue
Copy link
Contributor

@j08lue j08lue commented Dec 6, 2024

Closes

By

  • Change links to MyBinder to point at VEDA Binder
  • Add section explaining what Binder and VEDA Binder is

@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@j08lue j08lue requested a review from wildintellect December 6, 2024 13:12
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2024 •
edited
Loading

PR Preview Action v1.6.0

🚀 View preview at
https://NASA-IMPACT.github.io/veda-docs/pr-preview/pr-188/

Built to branch gh-pages at 2025-01-21 08:39 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

wildintellect
wildintellect reviewed Dec 6, 2024
View reviewed changes
Copy link
Collaborator

@wildintellect wildintellect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the links seem to be good (I tested some), made some comments around the descriptions, nothing is a blocker.

nasa-veda-platform/adding-content/docs-and-notebooks.qmd Outdated Show resolved Hide resolved
nasa-veda-platform/scientific-computing/index.qmd Outdated Show resolved Hide resolved
notebooks/index.qmd Outdated Show resolved Hide resolved
j08lue
j08lue commented Jan 21, 2025
View reviewed changes
notebooks/index.qmd Outdated Show resolved Hide resolved
@j08lue j08lue requested a review from wildintellect January 21, 2025 08:36
@j08lue
Copy link
Contributor Author

j08lue commented Jan 21, 2025 •
edited
Loading

@wildintellect I addressed your comments and recommend that we merge this for now and follow up on the discussion re Binder (now "VEDA Trial Hub") elsewhere.

Please review again.

@j08lue j08lue merged commit 3e639cd into main Jan 22, 2025
1 check passed
@j08lue j08lue deleted the feat/binderhub-links branch January 22, 2025 12:22
@wildintellect wildintellect mentioned this pull request Jan 23, 2025
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wildintellect wildintellect wildintellect approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@j08lue @wildintellect