Horizontal datum - revised #330
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the PR: This is a pull request for validating the presence of horizontal datum name. We make recommendation whenever the horizontal datum name is not present. The error message is revised as per the suggestions, and tested with sample record having a horizontal datum name.
Code change: Code changes are made in the
rules_override.jsonandcheck_messages_override.json(ignore the changes inchecks_override.json). Further, we updated the outdated files in thetest_downloader.pyandschema_validator.py. There was an outdated imports DraftValidator, and this has to be updated before every commit. The final code is test by running pytest, and the run was successful before committing the code changes.To reproduce:
C1000000018-CDDIS --format umm-c
C1422070882-CDDIS --format umm-c
C1406820051-CDDIS --format umm-c
Test file: Create a test file with the following format
{
"SpatialExtent": { "HorizontalSpatialDomain": { "ResolutionAndCoordinateSystem": {"GeodeticModel": { "HorizontalDatumName": "WGS 84"}}}}
}
Expected output:
