Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
c85e2f8 to
c22cf8d
Compare
c22cf8d to
d08ea29
Compare
d08ea29 to
a744ceb
Compare
a744ceb to
8a53443
Compare
8a53443 to
a6ede9a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR splits
ConnectionintoConnectioninit_watermark- no longer referencesreader_lo, defaults toConnection::committer_watermarkcommitter_watermark- same as beforeset_committer_watermark- same as beforeTrailingConnectiontrailing_init_watermark- same as previousConnection::init_watermarkreader_watermark- same as beforepruner_watermark- same as beforeset_reader_watermark- same as beforeset_pruner_watermark- same as beforeConnectionimpls:AnalyticsConnectionBigTableConnectionObjectStoreConnectionConnectionTrailingConnectionimpls:ConnectionMockConnectionTrailingConnectionextendsConnectionbecauseTrailingInitWatermarkandReaderWatermarkboth referencecheckpoint_hi_inclusive.Connection::init_watermarkdefaults toConnection::committer_watermarkfor impls that do not have initialization logic:AnalyticsConnectionBigTableConnectionObjectStoreConnectionConnectionConnection::init_watermarkis overridden in these impls:ConnectionMockConnectionTest plan
No new functionality.
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.