Skip to content

Indexer split connection#25881

Open
evan-wall-mysten wants to merge 3 commits intomainfrom
indexer_split_connection
Open

Indexer split connection#25881
evan-wall-mysten wants to merge 3 commits intomainfrom
indexer_split_connection

Conversation

@evan-wall-mysten
Copy link
Collaborator

@evan-wall-mysten evan-wall-mysten commented Mar 18, 2026

Description

This PR splits Connection into

  • Connection
    • init_watermark - no longer references reader_lo, defaults to Connection::committer_watermark
    • committer_watermark - same as before
    • set_committer_watermark - same as before
  • TrailingConnection
    • trailing_init_watermark - same as previous Connection::init_watermark
    • reader_watermark - same as before
    • pruner_watermark - same as before
    • set_reader_watermark - same as before
    • set_pruner_watermark - same as before

Connection impls:

  • AnalyticsConnection
  • BigTableConnection
  • ObjectStoreConnection
  • Consistent store Connection

TrailingConnection impls:

  • Postgres Connection
  • MockConnection

TrailingConnection extends Connection because TrailingInitWatermark and ReaderWatermark both reference checkpoint_hi_inclusive.

Connection::init_watermark defaults to Connection::committer_watermark for impls that do not have initialization logic:

  • AnalyticsConnection
  • BigTableConnection
  • ObjectStoreConnection
  • Consistent store Connection

Connection::init_watermark is overridden in these impls:

  • Postgres Connection
  • MockConnection

Test plan

No new functionality.


Release notes

Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.

For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

  • Protocol:
  • Nodes (Validators and Full nodes):
  • gRPC:
  • JSON-RPC:
  • GraphQL:
  • CLI:
  • Rust SDK:
  • Indexing Framework:

@vercel
Copy link

vercel bot commented Mar 18, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
sui-docs Ready Ready Preview, Comment Mar 19, 2026 4:58am
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
multisig-toolkit Ignored Ignored Preview Mar 19, 2026 4:58am
sui-kiosk Ignored Ignored Preview Mar 19, 2026 4:58am

Request Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant