[core] enable defer unpaid amplification #25867
Open
johnjmartin wants to merge 4 commits intomainfrom
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
johnjmartin
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
johnjmartin
force-pushed
the
jjm/amplification-enabled
branch
from
cf34790 to
af2c769
Compare
johnjmartin
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
johnjmartin
force-pushed
the
jjm/amplification-enabled
branch
from
af2c769 to
84df13f
Compare
johnjmartin
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
johnjmartin
force-pushed
the
jjm/amplification-enabled
branch
from
84df13f to
c3600f4
Compare
johnjmartin
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
johnjmartin
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
akichidis
approved these changes
Mar 17, 2026
mystenmark
reviewed
Mar 20, 2026
crates/sui-benchmark/src/lib.rs
Outdated
| for client in validators { | ||
| let req = request.clone(); | ||
| tokio::spawn(async move { | ||
| let _ = client.submit_transaction(req, None).await; |
Contributor
There was a problem hiding this comment.
does submit_transaction have a built-in timeout? if not we might want to add one to make sure that we can't pile up an unbounded number of tasks
mystenmark
reviewed
Mar 20, 2026
crates/sui-benchmark/src/lib.rs
Outdated
|
|
||
| let elapsed = start.elapsed(); | ||
|
|
||
| // Spawning should complete almost instantly, not wait for the tasks |
Contributor
There was a problem hiding this comment.
i'm not sure this test is necessary, its just testing basic tokio functionality that can't possibly break (without breaking literally everything in the world)
mystenmark
reviewed
Mar 20, 2026
| cfg.feature_flags.new_vm_enabled = true; | ||
| // Re-enable unpaid amplification deferral protection (devnet first) | ||
| if chain != Chain::Mainnet && chain != Chain::Testnet { | ||
| cfg.feature_flags.defer_unpaid_amplification = true; |
Contributor
There was a problem hiding this comment.
personally i think we could go to testnet right now, we're not going to get any signal on this from devnet
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
defer_unpaid_amplificationin protocol version 118Test plan
consensus_handler_unpaid_amplification_deferrals) confirmed activeRelease notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.