Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
amnn
reviewed
Mar 17, 2026
Contributor
amnn
left a comment
There was a problem hiding this comment.
The overall schema changes and shape looks good, but technically speaking, because zklogin verification depends on live object set queries, building this verification on top of gRPC is a consistency regression.
I believe most of the logic of signature verification is part of the new Rust SDK, however, so you should be able to avoid most duplication by building verification on top of that while preserving the consistent object queries we currently have for zkLogin.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Ed25519,Secp256k1,Secp256r1,MultiSig,ZkLogin,Passkey) by delegating to the fullnode gRPCSignatureVerificationServiceverifyZkLoginSignatureto avoid breaking existing SDKs before GraphQL GATest plan
How did you test the new or updated feature?
cargo nextest run -p sui-indexer-alt-graphqlRelease notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.