Skip to content

Implement verifySignature GraphQL query#25863

Open
tpham-mysten wants to merge 1 commit intomainfrom
tpham/graphql-verify-signature
Open

Implement verifySignature GraphQL query#25863
tpham-mysten wants to merge 1 commit intomainfrom
tpham/graphql-verify-signature

Conversation

@tpham-mysten
Copy link
Contributor

Description

  • Add a new verifySignature query that supports all signature types (Ed25519, Secp256k1, Secp256r1, MultiSig, ZkLogin, Passkey) by delegating to the fullnode gRPC SignatureVerificationService
  • Deprecate verifyZkLoginSignature to avoid breaking existing SDKs before GraphQL GA

Test plan

How did you test the new or updated feature?

  • cargo nextest run -p sui-indexer-alt-graphql
  • Manually tested with Ed25519 PersonalMessage against local GraphQL server + testnet fullnode gRPC

Release notes

Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.

For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

  • Protocol:
  • Nodes (Validators and Full nodes):
  • gRPC:
  • JSON-RPC:
  • GraphQL: Add new verifySignature
  • CLI:
  • Rust SDK:
  • Indexing Framework:

@tpham-mysten tpham-mysten requested a review from a team as a code owner March 17, 2026 14:13
@tpham-mysten tpham-mysten temporarily deployed to sui-typescript-aws-kms-test-env March 17, 2026 14:13 — with GitHub Actions Inactive
@vercel
Copy link

vercel bot commented Mar 17, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated (UTC)
multisig-toolkit Ignored Ignored Mar 17, 2026 2:13pm
sui-kiosk Ignored Ignored Mar 17, 2026 2:13pm

Request Review

Copy link
Contributor

@amnn amnn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The overall schema changes and shape looks good, but technically speaking, because zklogin verification depends on live object set queries, building this verification on top of gRPC is a consistency regression.

I believe most of the logic of signature verification is part of the new Rust SDK, however, so you should be able to avoid most duplication by building verification on top of that while preserving the consistent object queries we currently have for zkLogin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants