Skip to content

Better monitored_scope coverage #21608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 26, 2025
Merged

Better monitored_scope coverage #21608

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions crates/sui-core/src/checkpoints/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1228,6 +1228,7 @@ impl CheckpointBuilder {
&self,
pendings: Vec<PendingCheckpointV2>,
) -> anyhow::Result<CheckpointSequenceNumber> {
let _scope = monitored_scope("CheckpointBuilder::make_checkpoint");
let last_details = pendings.last().unwrap().details().clone();

// Keeps track of the effects that are already included in the current checkpoint.
Expand Down Expand Up @@ -1265,6 +1266,8 @@ impl CheckpointBuilder {
roots: Vec<TransactionKey>,
effects_in_current_checkpoint: &mut BTreeSet<TransactionDigest>,
) -> SuiResult<Vec<TransactionEffects>> {
let _scope = monitored_scope("CheckpointBuilder::resolve_checkpoint_transactions");

self.metrics
.checkpoint_roots_count
.inc_by(roots.len() as u64);
Expand All @@ -1280,8 +1283,6 @@ impl CheckpointBuilder {
.in_monitored_scope("CheckpointNotifyRead")
.await;

let _scope = monitored_scope("CheckpointBuilder");

let consensus_commit_prologue = if self
.epoch_store
.protocol_config()
Expand Down
Loading