[move-abstract-interpreter] Make move-abstract-interpreter more general #21574
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tnowacki
requested review from
cgswords,
awelc,
tzakian,
sblackshear and
dariorussi
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
tnowacki
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
tnowacki
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
tnowacki
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
tnowacki
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
sblackshear
reviewed
Mar 25, 2025
| type State: AbstractDomain; | ||
| type Error; | ||
| fn start(&mut self) -> Result<(), Self::Error>; | ||
| fn join( |
There was a problem hiding this comment.
I suspect that for fancier (non bytecode verifier) analyses, we are going to need fn widen(&mut self, pre: &mut Self::State, post: &Self::State) (or similar) as well. But I hesitate to change the abstract interpretation code for the verified to support this--wonder if we just want a copy.
There was a problem hiding this comment.
It is a good callout, and I think it is worth adding once we need it. For now though I hesitate mostly around adding it just in that we don't really know what shape it will take.
In other words, if we had a pass that we wanted to implement with widening, it would help inform the API a lot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Test plan
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.