-
Notifications
You must be signed in to change notification settings - Fork 11.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[move-model-2] Switch maps to IndexMap #21572
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good to me, although I wonder -- this will only keep relative declaration order but not full declaration order in docgen right? Or will it do full "declaration order" output? i.e.,
public struct B()
public enum A {
C
}
public struct D()
In docgen will this give something like
public struct B()
public struct D()
public enum A {
C
}
or will this give
public struct B()
public enum A {
C
}
public struct D()
For now
We could store the full index order in the |
Description
Test plan
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.