Better test coverage for consensus adapter max_in_flight behavior #21569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
mystenmark
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
andll
approved these changes
Mar 21, 2025
mystenmark
force-pushed
the
mlogan-consensus-adapter-tests
branch
from
6bc2315 to
27467eb
Compare
mystenmark
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
aschran
approved these changes
Mar 21, 2025
mwtian
approved these changes
Mar 21, 2025
| @@ -691,6 +692,31 @@ impl ConsensusAdapter { | |||
| .ok(); // result here indicates if epoch ended earlier, we don't care about it | |||
| } | |||
|
|
|||
| async fn acquire_submit_semaphore(&self) -> SemaphorePermit { | |||
| loop { | |||
| match tokio::time::timeout(Duration::from_secs(5), async { | |||
There was a problem hiding this comment.
This (5s) seems inconsistent with the error message later (30s). I think it is safer to use 30s which should still be low enough in tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to find bugs in which pending consensus transactions are never marked as processed.