Add debt-based trigger for observation sharing #21493
Merged
+71
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
aschran
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
Without this, some entrypoints could get stuck at high estimates with no way of adjusting back down.
aschran
force-pushed
the
aschran/cc-estimator-debt-trigger
branch
from
bdb24f3 to
f8de064
Compare
aschran
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
aschran
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
mystenmark
reviewed
Mar 13, 2025
| @@ -51,6 +51,9 @@ pub struct ExecutionTimeObserver { | |||
| // via consensus. | |||
| object_utilization_tracker: LruCache<ObjectID, ObjectUtilization>, | |||
|
|
|||
| // Sorted list of recently indebted objects, updated by consensus handler. | |||
| indebted_objects: Vec<ObjectID>, | |||
There was a problem hiding this comment.
repeating my comment from the stacked version of this commit: any reason you didn't use a HashSet?
There was a problem hiding this comment.
took an educated guess that this might be faster due to cache locality, since it should be small?
happy to change it if you think that's dumb and premature optimization - it wasn't a very thoroughly considered decision - wdyt?
There was a problem hiding this comment.
yeah if its small it might be faster. no need to change it, its just we don't do this anywhere else as far as i know.
mystenmark
approved these changes
Mar 13, 2025
aschran
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, some entrypoints could get stuck at high estimates with no way of adjusting back down.
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.