Enable ExecutionTimeEstimate mode for congestion control in testnet #21492
+82
−53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
aschran
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
aschran
force-pushed
the
aschran/cc-estimator-enable
branch
from
f86e122 to
f67376e
Compare
aschran
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
mystenmark
reviewed
Mar 13, 2025
| cfg.feature_flags.per_object_congestion_control_mode = | ||
| PerObjectCongestionControlMode::ExecutionTimeEstimate( | ||
| ExecutionTimeEstimateParams { | ||
| target_utilization: 30, |
There was a problem hiding this comment.
No reason - it seemed a bit safer to start than the 50 we eventually want to end up at. feel free to propose another number and I'll accept :)
mystenmark
reviewed
Mar 13, 2025
| ExecutionTimeEstimateParams { | ||
| target_utilization: 30, | ||
| allowed_txn_cost_overage_burst_limit_us: 100_000, // 100 ms | ||
| randomness_scalar: 20, |
There was a problem hiding this comment.
so this multiplies against target utilization meaning that target utilization for randomness txns will be 6%, right?
mystenmark
approved these changes
Mar 13, 2025
aschran
force-pushed
the
aschran/cc-estimator-enable
branch
from
f67376e to
3ca1b00
Compare
aschran
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
aschran
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
aschran
force-pushed
the
aschran/cc-estimator-enable
branch
from
668a8f0 to
3d91d3b
Compare
aschran
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
aschran
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
aschran
force-pushed
the
aschran/cc-estimator-enable
branch
from
7e0a34f to
e0b5cd9
Compare
aschran
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
aschran
force-pushed
the
aschran/cc-estimator-enable
branch
from
e0b5cd9 to
4b98d1e
Compare
aschran
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
aschran
force-pushed
the
aschran/cc-estimator-enable
branch
from
4b98d1e to
9cbf9f7
Compare
aschran
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
aschran
force-pushed
the
aschran/cc-estimator-enable
branch
from
9cbf9f7 to
d377337
Compare
aschran
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
aschran
force-pushed
the
aschran/cc-estimator-enable
branch
from
d377337 to
c210b47
Compare
aschran
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This enables a new congestion control mode that uses a predictive model for PTB command transaction time collaboratively built through consensus by validators.
Test plan
Unit tests, performance backtesting with tool in separate repo, manual inspection.
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.