Move config parameters for ExecutionTimeEstimate mode into protocol and node configs #21466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
aschran
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
aschran
force-pushed
the
aschran/cc-estimator-config
branch
from
aaa1398 to
d3f94bc
Compare
aschran
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
aschran
force-pushed
the
aschran/cc-estimator-config
branch
from
d3f94bc to
8b779fb
Compare
aschran
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
aschran
force-pushed
the
aschran/cc-estimator-config
branch
from
8b779fb to
e3e6a7d
Compare
aschran
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
aschran
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
aschran
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
aschran
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
aschran
added a commit
that referenced
this pull request
Mar 13, 2025
Also includes some minor cleanups, most notably removing the absolute limit param for this mode since we always set it to u64::MAX. Stacked on PR #21466
mystenmark
reviewed
Mar 13, 2025
| @@ -3001,12 +3009,12 @@ impl AuthorityPerEpochStore { | |||
| estimates, | |||
| } in execution_time_observations | |||
| { | |||
| let Some(estimator) = execution_time_estimator.as_mut() else { | |||
| error!("dropping ExecutionTimeObservation from possibly-Byzantine authority {authority:?} sent when ExecutionTimeEstimate mode is not enabled"); | |||
There was a problem hiding this comment.
maybe make this a debug_fatal! and then it'll get reported in metrics?
There was a problem hiding this comment.
the reason I didn't do this is it's not an invariant violation: any (non-)byzantine validator can send us an unexpected message if they feel like it and we should drop it, doesn't mean something broke locally
mystenmark
approved these changes
Mar 13, 2025
aschran
added a commit
that referenced
this pull request
Mar 13, 2025
Also includes some minor cleanups, most notably removing the absolute limit param for this mode since we always set it to u64::MAX. Stacked on PR #21466
aschran
added a commit
that referenced
this pull request
Mar 13, 2025
…nd node configs (#21466) --- Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] gRPC: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.