Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Preallocate capacity for known size vectors #17871

Merged
merged 1 commit into from
Jun 9, 2024

Conversation

howjmay
Copy link
Contributor

@howjmay howjmay commented May 22, 2024

Description

Initialize vector with capacity when the upcoming push() with known times.

Test plan

How did you test the new or updated feature?


Release notes

Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.

For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

  • Protocol:
  • Nodes (Validators and Full nodes):
  • Indexer:
  • JSON-RPC:
  • GraphQL:
  • CLI:
  • Rust SDK:

Copy link

vercel bot commented May 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sui-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 9, 2024 2:39pm

Copy link

vercel bot commented May 22, 2024

@howjmay is attempting to deploy a commit to the Mysten Labs Team on Vercel.

A member of the Team first needs to authorize it.

@amnn amnn removed the request for review from a team May 24, 2024 11:53
Copy link
Member

@mwtian mwtian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the optimization!

@mwtian mwtian enabled auto-merge (squash) June 9, 2024 17:58
@mwtian mwtian merged commit 57324c2 into MystenLabs:main Jun 9, 2024
39 of 43 checks passed
@howjmay
Copy link
Contributor Author

howjmay commented Jun 10, 2024

Thank you for review too

@howjmay howjmay deleted the vec-opt branch June 10, 2024 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants