Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sentiment-analysis #1517

Open
wants to merge 1 commit into
base: 21.02
Choose a base branch
from

Conversation

TREE-Ind
Copy link
Contributor

@TREE-Ind TREE-Ind commented Jun 9, 2021

Info

This PR adds the new skill, sentiment-analysis, to the skills repo.

Description

Perform basic sentiment analysis

Created with mycroft-skills-kit v0.3.16

@devops-mycroft
Copy link
Collaborator

Voight Kampff Integration Test Failed (Results).
Mycroft logs are also available: skills.log, audio.log, voice.log, bus.log, enclosure.log

@krisgesling
Copy link
Contributor

Hey Josh,

This is neat package! Interested to see where you take it.

It looks like MSK grabbed the wrong commit for the submodule. This is currently pointing to the commit: https://github.com/TREE-Ind/Sentiment-Analysis-Skill/tree/d14f4f292bc11456e517e32b2e66e14cb63378aa

Which I'm quite sure is not what you wanted :)

A few other suggestions:

  1. The template settingsmeta.yaml is still in the Skill - this should get removed if you're not using any Skill settings.

  2. We really need an automated test included so that we can verify that the Skill is not only working now, but so we can confirm that it continues to work as mycroft-core and other Skills change.
    The wallpaper tests from the new Homescreen Skill would be a good starting point here. The tests are here and the custom Step for "Then the wallpaper should be changed" is defined here. Basically it just detects whether the skill.homescreen.notify.wallpaper_changed message was emitted on the bus.
    Ping me if you need a hand with it

  3. The Message you emit should be namespaced to your Skill so that we avoid clashes with some other future Skill doing something with sentiments. Eg skill.sentiment_analysis.sentiment

  4. It looks like you have a duplicate method left in from testing - https://github.com/TREE-Ind/Sentiment-Analysis-Skill/blob/c2ba93678f651fb8185d37868c19b0a64f83377e/__init__.py#L15

  5. It might be useful to include in the data object on your Message whether the sentiment relates to an utterance from the user, or dialog being spoken by the system.

@krisgesling krisgesling added new New Skill (not update to existing Skill) waiting Waiting on the Skill Author to respond labels Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new New Skill (not update to existing Skill) waiting Waiting on the Skill Author to respond
Projects
No open projects
Status: Skill submission
Development

Successfully merging this pull request may close these issues.

None yet

3 participants