Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tx Receipt Type Changes #4238

Open
wants to merge 35 commits into
base: master
Choose a base branch
from
Open

Tx Receipt Type Changes #4238

wants to merge 35 commits into from

Conversation

blurpesec
Copy link
Collaborator

@blurpesec blurpesec commented Jan 2, 2022

Description

Makes changes to txReceipt types and make tx history panel and tx status panels more useful.

Changes

  • Added a token transfers section to txStatus.
  • Added sent/received asset(s) fields in tx history panel.
  • Changed up ITxReceipt types to handle valueTransfers (so we can display more than one asset transfer in txhistory and txstatus panels at a time).
  • Added a displayAsset field to redux state txs to better handle displays
  • Changed up txType derivations to better handle naming/labels/icons.
  • Added unknown erc721 and base asset value transfers (base is used for internal transactions when receiving eth from exchange txTypes).
  • Unified mtimes to be 1234567891011 in fixtures, so it's easier to test against them.

@mycrypto-bot
Copy link
Collaborator

Staging build: MyCryptoBuilds

@codecov
Copy link

codecov bot commented Jan 24, 2022

Codecov Report

Merging #4238 (d39b674) into master (144b8aa) will increase coverage by 0.66%.
The diff coverage is 97.92%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4238      +/-   ##
==========================================
+ Coverage   78.73%   79.40%   +0.66%     
==========================================
  Files         572      575       +3     
  Lines       12429    12593     +164     
  Branches     3068     3149      +81     
==========================================
+ Hits         9786     9999     +213     
+ Misses       2611     2564      -47     
+ Partials       32       30       -2     
Impacted Files Coverage Δ
src/components/Account.tsx 86.36% <ø> (ø)
...omponents/SignTransactionWallets/WalletConnect.tsx 84.09% <ø> (ø)
src/components/Table.tsx 83.87% <ø> (ø)
src/components/TransactionFlow/TxPendingState.tsx 100.00% <ø> (ø)
...s/TransactionFlow/displays/FaucetReceiptBanner.tsx 100.00% <ø> (ø)
...tectTransaction/components/ProtectTxProtection.tsx 46.15% <ø> (ø)
src/features/SwapAssets/components/SwapQuote.tsx 66.66% <ø> (ø)
src/features/Dashboard/components/helpers.ts 88.88% <90.00%> (+62.80%) ⬆️
...ts/TransactionFlow/displays/TokenTransferTable.tsx 90.90% <90.90%> (ø)
src/components/TransactionFlow/TxReceipt.tsx 86.80% <96.87%> (+0.19%) ⬆️
... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 144b8aa...d39b674. Read the comment docs.

@blurpesec blurpesec temporarily deployed to STAGING January 25, 2022 04:09 Inactive
@blurpesec blurpesec changed the title [WIP] Tx Receipt Type Changes Tx Receipt Type Changes Jan 27, 2022
Copy link
Collaborator

@FrederikBolding FrederikBolding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a big one. Sorry in advance 😅

Missing a bunch of tests, possibly a LS migration, should follow more of our code standards and possibly just a bit more polish.

Let me know if you have any questions about any comments - I suspect we'll need to iterate a bit on this before merging 👍

Since the PR is large I asked Maarten to take a look as well.

src/types/transaction.ts Outdated Show resolved Hide resolved
src/services/TxHistory/helpers.tsx Outdated Show resolved Hide resolved
src/types/transaction.ts Show resolved Hide resolved
src/services/TxHistory/helpers.tsx Outdated Show resolved Hide resolved
src/features/TxStatus/TxStatus.tsx Outdated Show resolved Hide resolved
src/services/Store/Asset/helpers.ts Outdated Show resolved Hide resolved
src/services/ApiService/History/types.ts Outdated Show resolved Hide resolved
src/services/ApiService/History/types.ts Outdated Show resolved Hide resolved
src/components/Amount.tsx Outdated Show resolved Hide resolved
src/components/Currency.tsx Outdated Show resolved Hide resolved
src/components/EthAddress.tsx Outdated Show resolved Hide resolved
src/services/TxHistory/helpers.tsx Outdated Show resolved Hide resolved
src/services/TxHistory/helpers.tsx Outdated Show resolved Hide resolved
src/services/TxHistory/helpers.tsx Outdated Show resolved Hide resolved
src/services/TxHistory/helpers.tsx Outdated Show resolved Hide resolved
src/services/TxHistory/types.ts Outdated Show resolved Hide resolved
@blurpesec blurpesec temporarily deployed to STAGING January 29, 2022 02:45 Inactive
@blurpesec blurpesec temporarily deployed to STAGING January 29, 2022 02:50 Inactive
@blurpesec blurpesec temporarily deployed to STAGING February 2, 2022 01:09 Inactive
@blurpesec blurpesec temporarily deployed to STAGING February 3, 2022 02:02 Inactive
@blurpesec blurpesec temporarily deployed to STAGING February 3, 2022 02:05 Inactive
@blurpesec blurpesec temporarily deployed to STAGING February 4, 2022 02:22 Inactive
@blurpesec blurpesec temporarily deployed to STAGING February 11, 2022 21:03 Inactive
@blurpesec blurpesec temporarily deployed to STAGING February 11, 2022 21:04 Inactive
@blurpesec blurpesec temporarily deployed to STAGING February 11, 2022 21:10 Inactive
@blurpesec blurpesec temporarily deployed to STAGING February 11, 2022 21:18 Inactive
@blurpesec blurpesec temporarily deployed to STAGING February 11, 2022 21:50 Inactive
@blurpesec blurpesec temporarily deployed to STAGING February 11, 2022 22:36 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants