Bad search names

[JoeCohen]

• Prevents saving Names which lack a search_name
• Prevents saving Names whose search_name is indistinct from that of an existing Name.
• Prevents saving Name whose author ends in a bad character. (Can end only in a letter or period.)
• Prevents saving Name whose author contains a bad character. See my comment below.
• Delivers Indistinct search_names #2712

Some Manual Tests

• Add a Name at rank Genus, without a period after L: Boletus L
  Expected Result: Redisplays form with flash: "Unable to save changes. Equivalent name exists: Boletus L. (14925)"
• Edit a Name., e.g edit Boletus edulis, adding a comma at the end of author.
  Expected Result: Flash error: "Unable to save changes. Name author must end only in a letter or period." Author field is emphasized with red border.
• Edit a Name., e.g edit Boletus edulis, enclosing author in parens.
  Expected Result: Flash error: "Unable to save changes. Name author must end only in a letter or period." Author field is emphasized with red border.
  Note: An author in the form (Blah) is incorrect. Parens enclose the author of the basionym, so (Blah) is missing the names of the authors of the re-classified name, or -- if it hasn't been reclassified -- there should be no parens.

[coveralls]

coverage: 93.449% (+0.005%) from 93.444%
when pulling 9a95a3b on jdc-2712-indistinct-search_names
into 5a2a8ac on main.

[JoeCohen]

• @mo-nathan, @nimmolo, @pellaea: rails db:migrate and/or rails db:load throw an Error if a validates macro includes a translated message, e.g. :symbol.t. In a perfect world that wouldn't happen. I left it as-is because:
  (1) A fix -- if one is possible -- is too deep for me. The issue is related to our .t extension and to how/when files get loaded. See the note in app/extensions/extensions.rb.
  (2) There's an easy work-around.
  I don't think it's worth anyone's time unless there's an easy, instant fix.
• @mo-nathan @pellaea . Should we allow brackets in author? The PR precludes them, and that makes it easier to find things. But it's unclear if the ICN precludes brackets. We had one bracketed author Name in the db, https://mushroomobserver.org/names/46228/versions?version=3, but I changed it to remove the brackets.
  MB has brackets, IF does not..
• We should consider doing more validations in the model.
  • It gets both the UI & API with one validation.
  • It's more Rails-conventional.
  • In many cases it nicely highlights the affected field in the model form.

[nimmolo]

Seems good to me. In favor of more validations on the model.

The class needs refactoring. A lot of Name modules can easily be broken off into POROs.