Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(CE): Added Mixpanel Destination Connector #556

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

xyfer17
Copy link
Contributor

@xyfer17 xyfer17 commented Dec 29, 2024

Description

  • Add Mixpanel Destination Connector
  • Add Unit Test for Mixpanel Connector

Related Issue

Relates to issue #396 Mixpanel: Destination Connector

Type of Change

  • New feature (non-breaking change which adds functionality)
  • New Connector (Destination or Source Connector)
  • Refactoring
  • Bug fix (non-breaking change which fixes an issue)
  • Styling change
  • Breaking change (fix or feature that would impact existing functionality)
  • Documentation update
  • Chore

How Has This Been Tested?

Checklist:

  • Added unit tests for the changes made (if required)
  • Ensure a branch name is prefixed with feature, bugfix, hotfix, release, style or chore followed by / and branch name e.g feature/add-salesforce-connector
  • Have you made sure the commit messages meets the guidelines?
  • Added relevant screenshots for the changes
  • Have you tested the changes on local/staging?
  • Added the new connector in rollout.rb
  • Have you updated the version number of the gem?
  • Have you ensured that your changes for new connector are documented in the docs repo or relevant documentation files?
  • Have you updated the run time dependency in multiwoven-integrations.gemspec if new gems are added
  • Have you made sure the code you have written follows the best practises to the best of your knowledge?

@Mohith93 Mohith93 requested a review from afthabvp January 1, 2025 14:03
send_request(endpoint, payload)
end

def send_request(endpoint, payload)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xyfer17 Is it possible to use Multiwoven::Integrations::Core::HttpClient.request for sending a request? Look at http destination connector for reference

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants