Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow RECORD in subfolders, such as what is provided in 'py', which c… #20

Merged
merged 2 commits into from
Jul 18, 2024

Conversation

mboisson
Copy link
Contributor

@mboisson mboisson commented Feb 7, 2022

…ontained vendored dependencies

Without this, I get an exception when trying to update a wheel for the package py.

The reason is that py includes vendored dependencies. This patch allows having that.
The error I get is:

Exception: Traceback (most recent call last):
  File "/home/mboisson/git/wheels_builder/manipulate_wheels.py", line 84, in main
    wf2 = WheelFile.from_wheelfile(wf, file_or_path=TMP_DIR, version=version)
  File "/cvmfs/soft.computecanada.ca/custom/python/envs/manipulate_wheels/lib/python3.8/site-packages/wheelfile.py", line 1484, in from_wheelfile
    new_wf.writestr(zinfo, wf.zipfile.read(zinfo))
  File "/cvmfs/soft.computecanada.ca/custom/python/envs/manipulate_wheels/lib/python3.8/site-packages/wheelfile.py", line 2051, in writestr
    self.refresh_record(arcname)
  File "/cvmfs/soft.computecanada.ca/custom/python/envs/manipulate_wheels/lib/python3.8/site-packages/wheelfile.py", line 1828, in refresh_record
    self.record.update(arcname, zf)
  File "/cvmfs/soft.computecanada.ca/custom/python/envs/manipulate_wheels/lib/python3.8/site-packages/wheelfile.py", line 727, in update
    assert not arcpath.endswith('.dist-info/RECORD'), (
AssertionError: Attempt to add an entry for a RECORD file to the RECORD: 'py/_vendored_packages/apipkg-2.0.0.dist-info/RECORD'.

This replaces #19

@MrMino MrMino merged commit cc89b4a into MrMino:master Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants