Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NETWORK_SITE_URL env var removal from files #12727

Merged
merged 7 commits into from
Aug 26, 2024

Conversation

dlopezvsr
Copy link
Collaborator

@dlopezvsr dlopezvsr commented Aug 21, 2024

Description

This PR removes NETWORK_SITE_URL env var from codebase and is replaced for origin property of the Location interface window.location.origin.

How to test

  • Due to there hasn't been a separate Network API for years (as the issue specifies), the way to test these changes is only making sure at the time we merge into staging the deletion of this var is not casuing any conflicts, and then remove also from prod.
  • Another way to test is is reviewing jobs from the from the continous-integration built properly. As you can see on previous commits under this PR some of the jobs failed due to NETWORK_SITE_URL removal from the github workflows, but it was already fixed using window.location.origin.

Link to sample test page: https://foundation-s-tp1-250-re-ubeqtp.herokuapp.com/en/
Related PRs/issues: #7613

Checklist

Tests

  • Is the code I'm adding covered by tests?

Changes in Models:

  • Did I update or add new fake data?
  • Did I squash my migration?
  • Are my changes backward-compatible. If not, did I schedule a deploy with the rest of the team?

Documentation:

  • Is my code documented?
  • Did I update the READMEs or wagtail documentation?

Merge Method
💡❗Remember to use squash merge when merging non-feature branches into main

┆Issue is synchronized with this Jira Story

@dlopezvsr dlopezvsr self-assigned this Aug 21, 2024
@dlopezvsr dlopezvsr temporarily deployed to foundation-s-tp1-250-re-ubeqtp August 21, 2024 20:25 Inactive
@dlopezvsr dlopezvsr temporarily deployed to foundation-s-tp1-250-re-ubeqtp August 22, 2024 18:34 Inactive
@dlopezvsr dlopezvsr temporarily deployed to foundation-s-tp1-250-re-ubeqtp August 22, 2024 22:47 Inactive
@dlopezvsr dlopezvsr temporarily deployed to foundation-s-tp1-250-re-ubeqtp August 22, 2024 22:55 Inactive
@dlopezvsr dlopezvsr temporarily deployed to foundation-s-tp1-250-re-ubeqtp August 22, 2024 23:44 Inactive
@dlopezvsr dlopezvsr temporarily deployed to foundation-s-tp1-250-re-ubeqtp August 23, 2024 00:00 Inactive
@dlopezvsr dlopezvsr marked this pull request as ready for review August 23, 2024 16:25
Copy link
Collaborator

@robdivincenzo robdivincenzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @dlopezvsr !

@dlopezvsr dlopezvsr temporarily deployed to foundation-s-tp1-250-re-ubeqtp August 26, 2024 22:23 Inactive
@dlopezvsr dlopezvsr merged commit 0a26e65 into main Aug 26, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants