Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move override methods from init file to new utils file #12717

Merged
merged 7 commits into from
Aug 27, 2024

Conversation

dlopezvsr
Copy link
Collaborator

@dlopezvsr dlopezvsr commented Aug 15, 2024

Description

This PR proposes a slightly different idea of the initial issue description due to some current limitations. Moving the override functions from the __init__.py file to utils.py causes some conflicts related to circular imports where wagtail complains. Also
https://code.djangoproject.com/ticket/31795#no1 resolution was negative with a wontfix response. Considering that, another file was created to avoid circular import conflicts (override_utils.py) where the functions were moved, and are imported from in the `init.py

How to test

  • Access the review app link.
  • Enter /pt-BR/* or /fy-NL/* URLs to validate they work as expected.

Link to sample test page: https://foundation-s-tp1-314-mo-emzc6g.herokuapp.com/
Related PRs/issues: #9844

Checklist

Tests

  • Is the code I'm adding covered by tests?

Changes in Models:

  • Did I update or add new fake data?
  • Did I squash my migration?
  • Are my changes backward-compatible. If not, did I schedule a deploy with the rest of the team?

Documentation:

  • Is my code documented?
  • Did I update the READMEs or wagtail documentation?

Merge Method
💡❗Remember to use squash merge when merging non-feature branches into main

@dlopezvsr dlopezvsr self-assigned this Aug 15, 2024
@dlopezvsr dlopezvsr temporarily deployed to foundation-s-tp1-314-mo-emzc6g August 15, 2024 20:23 Inactive
@dlopezvsr dlopezvsr temporarily deployed to foundation-s-tp1-314-mo-emzc6g August 15, 2024 20:25 Inactive
@dlopezvsr dlopezvsr marked this pull request as ready for review August 15, 2024 20:27
@dlopezvsr dlopezvsr temporarily deployed to foundation-s-tp1-314-mo-emzc6g August 15, 2024 21:07 Inactive
@dlopezvsr dlopezvsr temporarily deployed to foundation-s-tp1-314-mo-emzc6g August 16, 2024 15:28 Inactive
@dlopezvsr dlopezvsr temporarily deployed to foundation-s-tp1-314-mo-emzc6g August 16, 2024 16:25 Inactive
@dlopezvsr dlopezvsr temporarily deployed to foundation-s-tp1-314-mo-clr5jd August 27, 2024 15:41 Inactive
Copy link
Collaborator

@ramram-mf ramram-mf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks Diego

@dlopezvsr dlopezvsr temporarily deployed to foundation-s-tp1-314-mo-clr5jd August 27, 2024 16:15 Inactive
@dlopezvsr dlopezvsr merged commit 1f30b2a into main Aug 27, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants