Move override methods from init file to new utils file #12717
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR proposes a slightly different idea of the initial issue description due to some current limitations. Moving the override functions from the
__init__.py
file toutils.py
causes some conflicts related to circular imports where wagtail complains. Alsohttps://code.djangoproject.com/ticket/31795#no1 resolution was negative with a wontfix response. Considering that, another file was created to avoid circular import conflicts (
override_utils.py
) where the functions were moved, and are imported from in the `init.pyHow to test
Link to sample test page: https://foundation-s-tp1-314-mo-emzc6g.herokuapp.com/
Related PRs/issues: #9844
Checklist
Tests
Changes in Models:
Documentation:
Merge Method
💡❗Remember to use squash merge when merging non-feature branches into
main