Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better JS file orgnization for PNI #12700

Merged
merged 4 commits into from
Aug 21, 2024
Merged

Conversation

mmmavis
Copy link
Collaborator

@mmmavis mmmavis commented Aug 8, 2024

Description

Move some JS files to source/js/buyers-guide/template-js-handler/ directory for better file organization.

  • homepage-c-slider.js
  • newsletter-box.js
  • pni-mobile-nav.js and rename file to mobile-category-nav.js
  • product-tab.js

Link to sample test page: https://foundation-s-tp1-141-10-l9iclv.herokuapp.com/en/privacynotincluded/
Related PRs/issues: #10314

@mmmavis mmmavis temporarily deployed to foundation-s-tp1-141-10-l9iclv August 8, 2024 19:57 Inactive
@mmmavis mmmavis marked this pull request as ready for review August 8, 2024 20:55
@mmmavis mmmavis requested a review from ramram-mf August 8, 2024 20:59
@mmmavis mmmavis self-assigned this Aug 8, 2024
Copy link
Collaborator

@ramram-mf ramram-mf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mmmavis now its in a better state. LGTM 👍🏿

@mmmavis mmmavis merged commit dda5f64 into main Aug 21, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants