-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove wagtail utility routes for authentication #12655
Remove wagtail utility routes for authentication #12655
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @ramram-mf! Once merged to staging, let's double-check SSO login to make sure there's no magic happening with these routes behind the scenes 👍
It looks like this removal would affect the password protection endpoints so I'm reverting it and getting it back to development in order to rethink the PRs approach. |
This reverts commit fd1c05c.
Description
This PR removes the base wagtail utility routes from unauthenticated user access, while preserving custom url patterns needed by the app.
To test
Link to
/_util/login
(should 404): https://foundation-s-tp1-334-on-yog1kg.herokuapp.com/en/_util/login/Link to custom url serve pattern (should both work):
Link to sample test page: https://foundation-s-tp1-334-on-yog1kg.herokuapp.com/en/privacynotincluded/categories/health-exercise/
Related PRs/issues: #12062
┆Issue is synchronized with this Jira Story