Remove wagtail utility routes for authentication #12655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robdivincenzo
approved these changes
Aug 26, 2024
There was a problem hiding this comment.
LGTM @ramram-mf! Once merged to staging, let's double-check SSO login to make sure there's no magic happening with these routes behind the scenes 👍
|
It looks like this removal would affect the password protection endpoints so I'm reverting it and getting it back to development in order to rethink the PRs approach. |
ramram-mf
added a commit
that referenced
this pull request
Aug 26, 2024
This reverts commit fd1c05c.
ramram-mf
added a commit
that referenced
this pull request
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the base wagtail utility routes from unauthenticated user access, while preserving custom url patterns needed by the app.
To test
Link to
/_util/login(should 404): https://foundation-s-tp1-334-on-yog1kg.herokuapp.com/en/_util/login/Link to custom url serve pattern (should both work):
Link to sample test page: https://foundation-s-tp1-334-on-yog1kg.herokuapp.com/en/privacynotincluded/categories/health-exercise/
Related PRs/issues: #12062
┆Issue is synchronized with this Jira Story