Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal of .localized from entry #12623

Merged
merged 7 commits into from
Jul 22, 2024

Conversation

dlopezvsr
Copy link
Collaborator

@dlopezvsr dlopezvsr commented Jul 15, 2024

Description

.localized was removed from publication_hero.html template, where the attribute was applied in the breadcrumb_list (parent pages) for publication article or publication page.

I took as an example two article pages to validate that the breadcrumb was still redirecting to the current locale.

  1. http://localhost:8000/es/insights/strengthening-data-ecosystems-for-education-in-india/edtech-in-india/
  2. http://localhost:8000/en/campaigns/trained-for-deception-how-artificial-intelligence-fuels-online-disinformation/ranking-and-recommendation-systems/

image

image

Link to sample test page:
Related PRs/issues: #12428

Checklist

Tests

  • Is the code I'm adding covered by tests?

Changes in Models:

  • Did I update or add new fake data?
  • Did I squash my migration?
  • Are my changes backward-compatible. If not, did I schedule a deploy with the rest of the team?

Documentation:

  • Is my code documented?
  • Did I update the READMEs or wagtail documentation?

Merge Method
💡❗Remember to use squash merge when merging non-feature branches into main

┆Issue is synchronized with this Jira Story

@dlopezvsr dlopezvsr self-assigned this Jul 15, 2024
Copy link
Collaborator

@danielfmiranda danielfmiranda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dlopezvsr!

I just tested this out and can confirm that it is working. LGTM!

@dlopezvsr dlopezvsr temporarily deployed to foundation-s-feature-re-narmst July 17, 2024 21:34 Inactive
@dlopezvsr dlopezvsr temporarily deployed to foundation-s-feature-re-narmst July 18, 2024 14:53 Inactive
@dlopezvsr dlopezvsr temporarily deployed to foundation-s-feature-re-narmst July 22, 2024 19:05 Inactive
@dlopezvsr dlopezvsr merged commit dba578c into main Jul 22, 2024
6 checks passed
@dlopezvsr dlopezvsr deleted the feature/remove-localized-from-publication-hero branch July 22, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants