Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update add item widget button margins in Wagtail edit page UI. #12607

Merged
merged 3 commits into from
Jul 16, 2024

Conversation

ramram-mf
Copy link
Collaborator

@ramram-mf ramram-mf commented Jul 12, 2024

Description

This PR attempts to fix the misleading white-space that exists around the .c-sf-add-button elements, by displaying them closer to the previous element rather than the next one.

Current state:
image

Fixed state:
image

To test

  1. Login to the cms in the preview app.
  2. Authenticate with the credentials: admin2 for both user and password.
  3. Open any page for editing. Association by proximity should be elevated in the Add item buttons of the block widgets, it should reflect that it will append an item right after the element above.

Link to sample test page: https://foundation-s-tp1-561-ma-nwd1qy.herokuapp.com/cms/login/
Related PRs/issues: #12247

┆Issue is synchronized with this Jira Story

@ramram-mf ramram-mf temporarily deployed to foundation-s-tp1-561-ma-nwd1qy July 12, 2024 00:28 Inactive
@ramram-mf ramram-mf temporarily deployed to foundation-s-tp1-561-ma-nwd1qy July 15, 2024 19:49 Inactive
@ramram-mf ramram-mf marked this pull request as ready for review July 15, 2024 20:56
Copy link
Collaborator

@robdivincenzo robdivincenzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be a nice ux improvement for editors. Thanks @ramram-mf! 🚀

@ramram-mf ramram-mf temporarily deployed to foundation-s-tp1-561-ma-nwd1qy July 16, 2024 17:18 Inactive
@ramram-mf ramram-mf merged commit 480dc62 into main Jul 16, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants