Update ImageGridBlock with LinkBlock #12585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robdivincenzo
approved these changes
Jul 17, 2024
danielfmiranda
added
run visual regression tests
and removed
run visual regression tests
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Link to sample test page:
Related PRs/issues: TP1-820
This PR updates the
ImageGridBlockby replacing the url field, with a new link field that uses the LinkWithoutLabelBlock.Additionally, this PR includes the necessary migration files to introduce the new field, transfer existing data, and remove the old fields. The HTML template has also been updated to reflect this change.
Screenshots
CMS (Before):
Frontend (Before):
CMS (After):
Frontend (After):
┆Issue is synchronized with this Jira Story