Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated ImageTeaserBlock to use LinkBlock #12580

Merged
merged 14 commits into from
Jul 16, 2024
Merged

Conversation

danielfmiranda
Copy link
Collaborator

@danielfmiranda danielfmiranda commented Jul 3, 2024

Description

Related PRs/issues: TP1-825

This PR updates the ImageTeaserBlock by replacing the url, url_label, and styling fields, which previously rendered an optional link button, with a new link_button field that uses the LinkButtonBlock.

Additionally, this PR includes the necessary migration files to introduce the new field, transfer existing data, and remove the old fields. The HTML template has also been updated to reflect this change.

Screenshots

CMS (Before):

Screenshot 2024-07-03 at 4 08 39 PM

Front End (Before)

Screenshot 2024-07-03 at 16-08-55 Tell Amazon Require privacy policies for internet-connected devices - Mozilla Foundation

CMS (After):

Screenshot 2024-07-03 at 4 07 20 PM

Front End (After):

Screenshot 2024-07-03 at 16-07-28 Tell Amazon Require privacy policies for internet-connected devices - Mozilla Foundation

┆Issue is synchronized with this Jira Story

Copy link
Contributor

@AdalbertoMoz AdalbertoMoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great work Daniel! 💯

@danielfmiranda danielfmiranda merged commit 53801a3 into main Jul 16, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants