Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated VideoBlock to use LinkBlock #12577

Merged
merged 13 commits into from
Jul 15, 2024
Merged

Updated VideoBlock to use LinkBlock #12577

merged 13 commits into from
Jul 15, 2024

Conversation

danielfmiranda
Copy link
Collaborator

@danielfmiranda danielfmiranda commented Jul 3, 2024

Description

Related PRs/issues: TP1-821

This PR updates the VideoBlock by replacing the captionURL charfield with a new optional caption_url field that uses the LinkWithoutLabelBlock.

Additionally, this PR includes the necessary migrations to transfer the existing data to the new field and remove the old field. It also updates the VideoBlock StreamField factory and the HTML template to accommodate these changes.

Screenshots

CMS (Before):

Screenshot 2024-07-03 at 16-24-25 Editing Blog page Amazon Require Privacy Policies for Internet-Connected Devices - Wagtail

Frontend (Before)

Screenshot 2024-07-03 at 16-24-36 Amazon Require Privacy Policies for Internet-Connected Devices - Mozilla Foundation

CMS (After):

Screenshot 2024-07-03 at 16-21-49 Editing Blog page Amazon Require Privacy Policies for Internet-Connected Devices - Wagtail

Frontend (After)

Screenshot 2024-07-03 at 16-22-16 Amazon Require Privacy Policies for Internet-Connected Devices - Mozilla Foundation

┆Issue is synchronized with this Jira Story

Copy link
Collaborator

@AdalbertoMoz AdalbertoMoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work Daniel! LGTM 🚀

@danielfmiranda danielfmiranda merged commit b3ca639 into main Jul 15, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants