Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added related_topics as SynchronizedField #12235

Merged
merged 1 commit into from
Apr 19, 2024
Merged

Conversation

danielfmiranda
Copy link
Collaborator

@danielfmiranda danielfmiranda commented Apr 18, 2024

Description

Link to sample test page: https://foundation-s-299-relate-rtrq2d.herokuapp.com/en/blog/
Related PRs/issues: #9101

This PR adds related_topics to the Blog Index Page's as a SynchronizedField so changes to the list will be synchronized across translations.

Screenshots

Related Topics Box (EN) with "Mozilla Explains":

Screenshot 2024-04-18 at 16-56-02 Blog - Mozilla Foundation

Related Topics Box (ES) with "Mozilla Explains:

Screenshot 2024-04-18 at 16-56-39 Blog - Fundación Mozilla

Related Topics Box (EN) after removing "Mozilla Explains":

Screenshot 2024-04-18 at 16-57-04 Blog - Mozilla Foundation

Related Topics Box (ES) after syncing translations:

Screenshot 2024-04-18 at 16-57-31 Blog - Fundación Mozilla

Steps to test

  1. Visit the English blog page, scroll to the related topics box, and note that "(EN) Advocacy" is featured.
  2. Visit the French blog page, scroll to the related topics box, and note that "(FR) Advocacy" is featured.
  3. Edit the blog index page in the CMS (credentials: admin2/admin2)
  4. Uncheck "(EN) Advocacy" from the "related topics" section, and publish the page.
  5. Sync page translations
  6. Visit the English blog page, scroll to the related topics box, and note that "(EN) Advocacy" is no longer featured.
  7. Visit the French blog page, scroll to the related topics box, and note that "(FR) Advocacy" is no longer featured.
  8. If everything is working as expected, testing is complete!

┆Issue is synchronized with this Jira Story

@danielfmiranda danielfmiranda temporarily deployed to foundation-s-299-relate-rtrq2d April 19, 2024 00:01 Inactive
@danielfmiranda danielfmiranda marked this pull request as ready for review April 19, 2024 00:18
Copy link
Contributor

@TheoChevalier TheoChevalier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Works great

Copy link
Contributor

@jhonatan-lopes jhonatan-lopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great sleuthing @danielfmiranda! Awesome find!

Copy link
Collaborator

@robdivincenzo robdivincenzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find @danielfmiranda!

@danielfmiranda danielfmiranda merged commit e7403b8 into main Apr 19, 2024
8 checks passed
@data-sync-user
Copy link
Collaborator

➤ Simon Acosta Torres commented:

This PR was merged on April 19th.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants