Server side config check #136
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #135
Addresses #134
This uses a "dry-run" approach to try to determine if the server will require the topic to be recreated. Unfortunately, the server returns INVALID_CONFIG with an error message describing that the topic will need to be recreated so this just matches on the string "create a new topic" which is probably too brittle to make this useful in cases other than my specific case.
This does catch some errors at plan time that would otherwise only be caught at apply time, so it's still somewhat useful in general.
Note: diffToTopic and metaToTopic are identical except for the input type... I'm not sure how to make a function accept multiple types... It may have something to do with an interface, but I'm not sure.